Update testing code. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //compiledTemplate | ||
| var fn1 = _.template(templateCode1) | ||
| var fn2 = _.template(templateCode2) | ||
|
|
There was a problem hiding this comment.
因为它们只在某个测试用例中用到，所以移进去，不需要暴露给其它代码。
| expect(_cacheCompiledTemplate).to.deep.equal({}) | ||
|
|
||
| var fn1 = _.template(templateCode1) |
There was a problem hiding this comment.
fn1和fn2赋值可以再晚点执行，用的时候再执行。不过没什么太大差异啦。
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 PR #20 的基础上继续修改测试代码。