Fix .add() 无法覆盖同名模板的问题，并增加相应单元测试
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| template.add(TEMPLATE_ID_2, templateCode2) | ||
| data[TEMPLATE_ID_2] = templateCode2 | ||
| template.add(TEMPLATE_ID_1, templateCode2) | ||
| data[TEMPLATE_ID_1] = templateCode2 |
There was a problem hiding this comment.
我觉得写错了，我认为应该这么测试：add一次id为TEMPLATE_ID_1的模板templateCode1，然后再add一次同名的模板templateCode2， data是正确的，然后比较_cacheTemplate和data是否一致。
cssmagic
added a commit
that referenced
this pull request
Nov 2, 2015
Fix `.add()` 无法覆盖同名模板的问题，并增加相应单元测试
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.