Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix groupversion for multicasskop #131

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Fix groupversion for multicasskop #131

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b812dd3
Fix groupversion for multicasskop
AKamyshnikova Oct 24, 2023
5a5602d
Drop readiness/liveness probes for multi-casskop
AKamyshnikova Oct 26, 2023
61521b5
Add dummy health checks for multi-casskop operator
AKamyshnikova Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions charts/multi-casskop/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,6 @@ spec:
{{- range .Values.k8s.remote }}
- -r{{ . }}
{{- end }}
readinessProbe:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this ? This is managed by k8s itself so why remove this ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are health checks provided with controller-runtime - in casskop we have https://github.com/cscetbon/casskop/blob/master/main.go#L205
But multicluster-controller does not have such functionality.

httpGet:
path: /readyz
port: 8081
initialDelaySeconds: 4
periodSeconds: 10
failureThreshold: 1
livenessProbe:
httpGet:
path: /healthz
port: 8081
initialDelaySeconds: 4
periodSeconds: 10
failureThreshold: 1
resources:
{{ toYaml .Values.resources | indent 10 }}
env:
Expand Down