-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix groupversion for multicasskop #131
Fix groupversion for multicasskop #131
Conversation
Were you able to test it locally @AKamyshnikova ? |
@cscetbon Yes, checked locally
|
057b124
to
becd0f6
Compare
Also updated setup namespace for casskop(drop depricated usage of namespace) Fixes: cscetbon#123
Probes readz/healthz are not enabled for admiralty.io/multicluster-controller.
becd0f6
to
5a5602d
Compare
@@ -50,20 +50,6 @@ spec: | |||
{{- range .Values.k8s.remote }} | |||
- -r{{ . }} | |||
{{- end }} | |||
readinessProbe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this ? This is managed by k8s itself so why remove this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are health checks provided with controller-runtime - in casskop we have https://github.com/cscetbon/casskop/blob/master/main.go#L205
But multicluster-controller does not have such functionality.
cd67f63
to
61521b5
Compare
Also updated setup namespace for casskop(drop deprecated usage of namespace)
Fixes: #123