Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML-DSA: Key generation across all parameter sets. #292

Merged
merged 10 commits into from
Jun 4, 2024
Merged

ML-DSA: Key generation across all parameter sets. #292

merged 10 commits into from
Jun 4, 2024

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented May 29, 2024

No description provided.

@xvzcf xvzcf marked this pull request as draft May 29, 2024 21:39
@xvzcf xvzcf changed the title ML-DSA: NTT functions. ML-DSA: Key generation across all parameter sets. May 31, 2024
@xvzcf xvzcf marked this pull request as ready for review May 31, 2024 17:00
@franziskuskiefer franziskuskiefer mentioned this pull request Jun 3, 2024
Closed
franziskuskiefer
franziskuskiefer approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@xvzcf xvzcf merged commit c49f78c into dev Jun 4, 2024
39 checks passed
@xvzcf xvzcf deleted the goutam/ml-dsa-ntt branch June 4, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

@karthikbhargavan karthikbhargavan Awaiting requested review from karthikbhargavan

Assignees
No one assigned
Labels
None yet
Projects
libcrux
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xvzcf @franziskuskiefer