Feature improve notification service generics

[agrancaric]

Basic information

• nrich version:
  1.2.1
• Module:
  nrich-notification, nrich-webmvc, nrich-logging

Additional information

Description

Summary

Added a separate class to represent a response notification without data, renamed existing class to end with Response suffix, renamed existing and added an additional interface in NotificationResolverService hierarchy that makes the usage easier.

Details

Added a separate class to represent a response notification without data, renamed existing class to end with Response suffix, renamed existing and added an additional interface in NotificationResolverService hierarchy that makes the usage easier.

Related issue

#68

Types of changes

• Breaking change (fix, enhancement or feature that would cause existing functionality to change in backward-incompatible way)

Checklist

• I have read the project's CONTRIBUTING document
• I have checked my code with the project's static analysis tooling
• I have formatted my code with the project's IDEA code-style configuration
• I have checked my code for misspellings
• I have organized my changes in easy-to-follow commits
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests pass.

[codecov-commenter]

Codecov Report

Merging #70 (981f9c9) into master (8806bdd) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
+ Coverage     95.85%   95.86%   +0.01%     
- Complexity     1002     1005       +3     
============================================
  Files           149      151       +2     
  Lines          2411     2418       +7     
  Branches        224      224              
============================================
+ Hits           2311     2318       +7     
  Misses           39       39              
  Partials         61       61              

Impacted Files	Coverage Δ
...ation/api/service/NotificationResponseService.java	100.00% <ø> (ø)
...figuration/NrichNotificationAutoConfiguration.java	100.00% <ø> (ø)
...er/configuration/NrichWebMvcAutoConfiguration.java	100.00% <ø> (ø)
...NotificationErrorHandlingRestControllerAdvice.java	94.59% <ø> (ø)
...ication/api/response/NotificationDataResponse.java	100.00% <100.00%> (ø)
...n/api/service/BaseNotificationResponseService.java	100.00% <100.00%> (ø)
...ion/service/WebMvcNotificationResponseService.java	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8806bdd...981f9c9. Read the comment docs.