Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generic parameters in nrich-notification #68

Closed
agrancaric opened this issue Mar 29, 2022 · 0 comments · Fixed by #70
Closed

Fix generic parameters in nrich-notification #68

agrancaric opened this issue Mar 29, 2022 · 0 comments · Fixed by #70
Assignees
Labels
enhancement New feature or request

Comments

@agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    nrich-notification

Additional information

Enhancement description

Currently notification services have generics that make them hard to use, the default provided bean is of type NotificationResponseService<ResponseWithNotification<?>> that then causes sonar warning and requires casts to be able to use effectively, this should be refactored in a way that avoids wildcards.

Current behaviour

Wildcards in NotificationResponseService type parameters.

Wanted behaviour

No wildcards in NotificationResponseService type parameters.

Possible workarounds

@agrancaric agrancaric added the enhancement New feature or request label Mar 29, 2022
@agrancaric agrancaric self-assigned this Mar 29, 2022
@agrancaric agrancaric linked a pull request Apr 2, 2022 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant