Bugfix fix dependencies #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
============================================
- Coverage 96.13% 96.09% -0.04%
Complexity 1017 1017
============================================
Files 152 152
Lines 2434 2435 +1
Branches 224 224
============================================
Hits 2340 2340
- Misses 34 35 +1
Partials 60 60
Continue to review full report at Codecov.
|
ea6d1c7 to
1da3939
Compare
1da3939 to
3337ce5
Compare
…rich-encrypt-spring-boot-starter module
…rich-excel-spring-boot-starter module
…ich-form-configuration-spring-boot-starter module
…stry-spring-boot-starter module
…ch-spring-boot-starter module
…rich-security-csrf-spring-boot-starter module
…vc-spring-boot-starter module
…of org.glassfish:jakarta.el to be inline with spring (see spring-projects/spring-boot#24744 for details)
… to webMvcImplementation scope
…oot-starter module
…h-spring-boot module
…ring-core on implementation scope instead in nrich-excel module
…ch-registry module
…ation-spring-boot-starter module
…nly scope in nrich-form-configuration-spring-boot-starter module
…-validation module
…nly scope in nrich-registry-spring-boot-starter module
…ng-boot-starter module to runtimeOnly and use spring-boot-autoconfigure on implementation scope instead
…ich-notification-spring-boot-starter on runtimeOnly scope in nrich-webmvc-spring-boot-starter module
d085435 to
1375224
Compare
jsajlovic
previously approved these changes
Apr 20, 2022
Explicitly define LoggingService bean in nrich-webmvc-spring-boot-starter
This should be removed when spring-boot-starter module for logging is introduced.
…ebMvcAutoConfiguration
jsajlovic
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic information
1.2.1
Project
Additional information
Description
Summary
Update gradle dependencies to use minimum required for using the modules, switch to starters in nrich-search and nrich-registry modules to ensure all the required dependencies are in place for running the module.
Details
Update gradle dependencies to use minimum required for using the modules, switch to starters in nrich-search and nrich-registry modules to ensure all the required dependencies are in place for running the module.
Related issue
#40
Types of changes
Checklist
My change requires a change to the documentationI have updated the documentation accordinglyI have added tests to cover my changes