Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies in modules #40

Closed
agrancaric opened this issue Mar 15, 2022 · 0 comments · Fixed by #65
Closed

Fix dependencies in modules #40

agrancaric opened this issue Mar 15, 2022 · 0 comments · Fixed by #65
Assignees
Labels
bug Something isn't working
Milestone

Comments

@agrancaric
Copy link
Collaborator

Basic information

  • nrich version:
    1.2.1
  • Module:
    Project
  • Link to the complete executable reproducer if available (e.g. GitHub Repo):

Additional information

Bug description

It seems that not all projects declare required dependencies while other have extra dependencies, they should all just use a minimal set off required dependencies. This has been seen in nrich-form-configuration module but would be best to go through all the modules.

Steps to reproduce

Add each of the modules and see if they can be run without additional configuration. It would be best to use "pure" Spring project because Spring Boot will probably cover all the dependencies.

Expected behavior

All modules work without adding additional dependencies manually .

Actual behavior

Not all modules work without adding additional dependencies.

@agrancaric agrancaric added the bug Something isn't working label Mar 15, 2022
@agrancaric agrancaric self-assigned this Mar 22, 2022
@agrancaric agrancaric mentioned this issue Mar 25, 2022
6 tasks
@agrancaric agrancaric linked a pull request Mar 25, 2022 that will close this issue
6 tasks
@jsajlovic jsajlovic added this to the v1.3.0 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants