Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification timestamp to allow frontend display and easier handling #115

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Jun 9, 2022

Basic information

  • nrich version:
    1.4.0
  • Module:
    nrich-notification-api, nrich-webmvc, nrich-webmvc-spring-boot-starter

Additional information

Description

Summary

Added notification timestamp to allow frontend display and easier handling (can be used as key when using React as frontend)

Details

Added notification timestamp to allow frontend display and easier handling (can be used as key when using React as frontend)

Related issue

Types of changes

  • Enhancement (non-breaking change which enhances existing functionality)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #115 (0d3d930) into master (57caa93) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0d3d930 differs from pull request most recent head c7f96c6. Consider uploading reports for the commit c7f96c6 to get more accurate results

@@             Coverage Diff              @@
##             master     #115      +/-   ##
============================================
- Coverage     96.62%   96.62%   -0.01%     
+ Complexity     1052     1050       -2     
============================================
  Files           155      155              
  Lines          2492     2486       -6     
  Branches        231      231              
============================================
- Hits           2408     2402       -6     
  Misses           31       31              
  Partials         53       53              
Impacted Files Coverage Δ
...ration/controller/FormConfigurationController.java 100.00% <0.00%> (ø)
...ation/service/DefaultFormConfigurationService.java 100.00% <0.00%> (ø)
...et/croz/nrich/javascript/model/JavascriptType.java
...cript/util/JavaToJavascriptTypeConversionUtil.java
...i/configuration/model/property/JavascriptType.java 100.00% <0.00%> (ø)
...ation/util/JavaToJavascriptTypeConversionUtil.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf7843...c7f96c6. Read the comment docs.

@agrancaric agrancaric requested a review from jsajlovic June 27, 2022 11:48
@agrancaric agrancaric force-pushed the feature_addNotificationTimestamp branch from deb97a4 to 0d3d930 Compare June 27, 2022 11:48
@jzrilic jzrilic changed the title Add Notification timestamp to allow frontend display and easier handl… Add Notification timestamp to allow frontend display and easier handling Jul 5, 2022
…ing (can be used as key when using React as frontend)
@jzrilic jzrilic force-pushed the feature_addNotificationTimestamp branch from 0d3d930 to c7f96c6 Compare July 5, 2022 14:26
@jzrilic jzrilic merged commit c113348 into master Jul 5, 2022
@jzrilic jzrilic deleted the feature_addNotificationTimestamp branch July 5, 2022 14:39
@jzrilic jzrilic added this to the v1.4.1 milestone Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants