Add Notification timestamp to allow frontend display and easier handl…

…ing (can be used as key when using React as frontend)
croz-ltd · Jun 27, 2022 · 0d3d930 · 0d3d930
1 parent 7dc91bb
commit 0d3d930
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/nrich-notification-api/src/main/java/net/croz/nrich/notification/api/model/Notification.java b/nrich-notification-api/src/main/java/net/croz/nrich/notification/api/model/Notification.java
@@ -21,6 +21,7 @@
 import lombok.NoArgsConstructor;
 import lombok.RequiredArgsConstructor;
 
+import java.time.Instant;
 import java.util.List;
 import java.util.Map;
 
@@ -57,4 +58,8 @@ public class Notification {
      */
     private final Map<String, ?> uxNotificationOptions;
 
+    /**
+     * Timestamp of the notification.
+     */
+    private final Instant timestamp = Instant.now();
 }
diff --git a/nrich-webmvc-spring-boot-starter/build.gradle b/nrich-webmvc-spring-boot-starter/build.gradle
@@ -13,6 +13,8 @@ dependencies {
   runtimeOnly project(":nrich-logging-spring-boot-starter")
   runtimeOnly project(":nrich-notification-spring-boot-starter")
 
+  runtimeOnly "com.fasterxml.jackson.datatype:jackson-datatype-jsr310"
+
   implementation "org.springframework.boot:spring-boot-autoconfigure"
 
   testImplementation project(":nrich-logging-spring-boot-starter")

diff --git a/nrich-webmvc/build.gradle b/nrich-webmvc/build.gradle
@@ -12,6 +12,8 @@ dependencies {
   implementation "jakarta.validation:jakarta.validation-api"
   implementation "org.springframework:spring-webmvc"
 
+  runtimeOnly "com.fasterxml.jackson.datatype:jackson-datatype-jsr310"
+
   testAnnotationProcessor "org.projectlombok:lombok"
   testCompileOnly "org.projectlombok:lombok"
 

diff --git a/.../java/net/croz/nrich/webmvc/advice/NotificationErrorHandlingRestControllerAdviceTest.java b/.../java/net/croz/nrich/webmvc/advice/NotificationErrorHandlingRestControllerAdviceTest.java
@@ -37,6 +37,8 @@ class NotificationErrorHandlingRestControllerAdviceTest extends BaseControllerTe
 
     private static final String NOTIFICATION_VALIDATION_ERROR_LIST_PATH = "$.notification.validationErrorList[0]";
 
+    private static final String NOTIFICATION_TIMESTAMP_PATH = "$.notification.timestamp";
+
     @Test
     void shouldResolveExceptionNotification() throws Exception {
         // given
@@ -49,7 +51,8 @@ void shouldResolveExceptionNotification() throws Exception {
         result.andExpect(status().isBadGateway())
             .andExpect(jsonPath(NOTIFICATION_TITLE_PATH).value("Error"))
             .andExpect(jsonPath(NOTIFICATION_CONTENT_PATH).value("Error message"))
-            .andExpect(jsonPath(NOTIFICATION_MESSAGE_LIST_PATH).value(startsWith("UUID")));
+            .andExpect(jsonPath(NOTIFICATION_MESSAGE_LIST_PATH).value(startsWith("UUID")))
+            .andExpect(jsonPath(NOTIFICATION_TIMESTAMP_PATH).isNotEmpty());
     }
 
     @Test