Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Docker caching. #650

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Improve Docker caching. #650

merged 3 commits into from
Mar 15, 2022

Conversation

reitermarkus
Copy link
Member

Also use pushed images as cache.

@reitermarkus reitermarkus requested a review from a team as a code owner March 14, 2022 22:17
@reitermarkus
Copy link
Member Author

bors try

1 similar comment
@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Try #650:
8174290
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Try #650:
654645a
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Try #650:
71dfedc
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build failed:

@reitermarkus
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors
Try #650:
a1248ce
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

try

Build succeeded:

@Emilgardis
Copy link
Member

--cache-from type=registry,ref=ghcr.io/cross-rs/{target}:trying

it should probably just use edge/main

@reitermarkus reitermarkus requested a review from Emilgardis March 15, 2022 16:33
@Emilgardis
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

👎 Rejected by too few approved reviews

Emilgardis
Emilgardis previously approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @reitermarkus
Merge #650
adfc6f4 
650: Improve Docker caching. r=Emilgardis a=reitermarkus

Also use pushed images as cache.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build failed:

@Emilgardis
Copy link
Member

lets try again

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @reitermarkus
Merge #650
145b6ce 
650: Improve Docker caching. r=Emilgardis a=reitermarkus

Also use pushed images as cache.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build failed:

@Emilgardis
Copy link
Member

these spurious errors are strange

bors r+

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @reitermarkus
Merge #650
722efbd 
650: Improve Docker caching. r=Emilgardis a=reitermarkus

Also use pushed images as cache.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build failed:

@reitermarkus
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Mar 15, 2022
@bors @reitermarkus
Merge #650
f83a7fb 
650: Improve Docker caching. r=Emilgardis a=reitermarkus

Also use pushed images as cache.

Co-authored-by: Markus Reiter <me@reitermark.us>
@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Canceled.

@reitermarkus reitermarkus requested a review from Emilgardis March 15, 2022 21:30
Emilgardis
Emilgardis approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 15, 2022

Build succeeded:

@bors bors bot merged commit ed729e7 into cross-rs:main Mar 15, 2022
@reitermarkus reitermarkus deleted the docker-cache branch March 15, 2022 22:44
@Emilgardis Emilgardis added this to the v0.2.2 milestone Jun 15, 2022
@Alexhuszagh Alexhuszagh added container-images A-linux Area: linux targets labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
A-linux Area: linux targets container-images
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@reitermarkus @Emilgardis @Alexhuszagh