Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Disorganised wallet feature #183

Open
damoncro opened this issue Oct 20, 2022 · 0 comments
Open

Problem: Disorganised wallet feature #183

damoncro opened this issue Oct 20, 2022 · 0 comments
Assignees
@damoncro

Comments

@damoncro
Copy link
Contributor

damoncro commented Oct 20, 2022 •
edited
Loading

Few things,

  1. wallets functions are coupled with DefiWalletCoreActor -> Decouple them, and turn wallet as wallet component, so that wallet can attach to any actor instead of only DefiWalletCoreActor and/or its dependents.
  2. All wallets depends on a private pointer: _coreWallet on the actor. -> We could change to object oriented design.
  3. Most of wallet functions are not exposed -> bind more wallet functions from play-cpp-sdk to unreal.
@damoncro damoncro changed the title Problem: Disorganised wallet features Problem: Disorganised wallet feature Oct 20, 2022
@damoncro damoncro self-assigned this Oct 20, 2022
damoncro added a commit that referenced this issue Oct 21, 2022
@damoncro
Problem: Disorganised wallet feature (fix #183)
969f70a 
- Add WalletComponent
This was referenced Oct 24, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damoncro damoncro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@damoncro