Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: wallet functions should not hardcode the network and index setting #182

Closed
damoncro opened this issue Oct 12, 2022 · 2 comments
Closed

Comments

@damoncro
Copy link
Contributor

Now it hardcodes cronos mainnet and index 0.

@damoncro
Copy link
Contributor Author

damoncro commented Oct 12, 2022

Just double checked, since the wallet (_coreWallet variable) is a private data of DefiWalletCoreActor (we need documentations to mention about it, one actor is one wallet), and the functions InitializeWallet and InitializeNewDevelopmentOnlyWallet call get_address function to get the first address on CryptoOrgMainnet mainnet, return the address as output.

@damoncro
Copy link
Contributor Author

Close and follow in #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant