Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Explicitly use PyCaret >= 3 #35

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Dependencies: Explicitly use PyCaret >= 3 #35

merged 1 commit into from
Dec 5, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Dec 5, 2024

Problem

Looks like the package installer selects an old version of PyCaret when updating pandas, now after llvmlite has been bumped, which trips with a funny error message.

help: `pyyaml` (v5.4.1) was included because `pycaret` (v2.3.10) depends
        on `pyyaml`

-- https://github.com/crate/academy-fundamentals-course/actions/runs/12187513828/job/33998467147?pr=27#step:6:107

Solution?

This patch bumps the requirements definition to explicitly use PyCaret >=3.

Q&A

@zanieb: Coming from #32 (comment), is it also related to this issue, that uv is acting so conservatively here that it is apparently biased to select the lowest available package version again?

@amotl amotl marked this pull request as ready for review December 5, 2024 20:41
@amotl amotl merged commit 60c5794 into main Dec 5, 2024
2 checks passed
@amotl amotl deleted the deps-pycaret branch December 5, 2024 20:42
@zanieb
Copy link
Contributor

zanieb commented Dec 5, 2024

It's less about conservatism, and more about the order in which packages are resolved. Roughly: due to the design of PubGrub, we solve for a single package at a time. If none of the recent versions of that package are compatible with the current state of the resolver, we can end up backtracking to a very old version before trying to change the version of a different package. Adding a lower bound that actually reflects your expectations will cause us to change versions of other packages sooner when looking for a solution.

@amotl
Copy link
Member Author

amotl commented Dec 5, 2024

Thanks a stack for the very detailed explanation. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants