Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pandas requirement from <2.1 to <2.3 #27

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2024

Updates the requirements on pandas to permit the latest version.

Release notes

Sourced from pandas's releases.

Pandas 2.2.3

We are pleased to announce the release of pandas 2.2.3. This release includes some new features, bug fixes, and performance improvements. We recommend that all users upgrade to this version.

See the full whatsnew for a list of all the changes. Pandas 2.2.3 supports Python 3.9 and higher.

The release will be available on the defaults and conda-forge channels:

conda install pandas

Or via PyPI:

python3 -m pip install --upgrade pandas

Please report any issues with the release on the pandas issue tracker.

Thanks to all the contributors who made this release possible.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 4, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@amotl

This comment was marked as outdated.

@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from 5bceda0 to bd33343 Compare November 5, 2024 10:59
@amotl
Copy link
Member

amotl commented Nov 5, 2024

That's a strange outcome on this CI run. Will need to be investigated later.

Failed to download and build `llvmlite==0.36.0`
RuntimeError: Cannot install on Python version {3.10.15,3.12.7}; only versions
>=3.6,<3.10 are supported.

-- https://github.com/crate/academy-fundamentals-course/actions/runs/11682753989/job/32530551814?pr=27#step:6:36

@amotl

This comment was marked as outdated.

@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from bd33343 to 7aeb70b Compare December 5, 2024 19:01
@amotl
Copy link
Member

amotl commented Dec 5, 2024

Failed to download and build llvmlite==0.36.0

I don't know why it is selecting such an old version of llvmlite-0.36.0, published on Mar 12, 2021.

Edit: Seems to be pulled in by pyod and numba, but it still does not make sense to select such an old version. Added 2f327f1 per GH-32 to evaluate it.

@amotl

This comment was marked as outdated.

@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from 7aeb70b to 15b0fd8 Compare December 5, 2024 20:10
@amotl

This comment was marked as outdated.

@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from 15b0fd8 to 973c4c0 Compare December 5, 2024 20:26
@amotl

This comment was marked as outdated.

@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from 973c4c0 to bdae4ed Compare December 5, 2024 20:42
@amotl
Copy link
Member

amotl commented Dec 5, 2024

@dependabot rebase

Updates the requirements on [pandas](https://github.com/pandas-dev/pandas) to permit the latest version.
- [Release notes](https://github.com/pandas-dev/pandas/releases)
- [Commits](pandas-dev/pandas@0.3.0...v2.2.3)

---
updated-dependencies:
- dependency-name: pandas
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/pandas-lt-2.3 branch from bdae4ed to c8a5a7f Compare December 5, 2024 21:52
@amotl
Copy link
Member

amotl commented Dec 5, 2024

CellTimeoutError raised on Python 3.12 is not related to uv selecting old dependency packages. So, GH-37 can be reverted.

-- https://github.com/crate/academy-fundamentals-course/actions/runs/12188668332/job/34002173577?pr=27#step:6:223

Still, why does it work on Python 3.10 but fails on Python 3.12? Apparently, it is happening on pip install?

@amotl
Copy link
Member

amotl commented Dec 5, 2024

to be able to see where time is spent, because updating pandas per #27 runs into a timeout

It is happening because it is building pandas from within the Jupyter Notebook, which does not fit into 60 seconds of runtime. Updating requirements.txt here does not help, because the Jupyter Notebook uses the version that is still on GitHub, because it uses an absolute URL. It has to use an absolute URL, because otherwise the Notebook would not work well on Google Colab.

So, this is a classic dead lock situation, and we will resolve it by force-merging.

@amotl amotl merged commit 6c6409a into main Dec 5, 2024
1 of 2 checks passed
@amotl amotl deleted the dependabot/pip/pandas-lt-2.3 branch December 5, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant