Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Update #22

Merged
merged 1 commit into from
Jun 21, 2024

Remove unneccesary routines, update load_rom to close stream.

a0f7a93
Select commit
Loading
Failed to load commit list.
Merged

Compatibility Update #22

Remove unneccesary routines, update load_rom to close stream.
a0f7a93
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jun 21, 2024 in 1s

90.10% (-3.28%) compared to afc9d70

View this Pull Request on Codecov

90.10% (-3.28%) compared to afc9d70

Details

Codecov Report

Attention: Patch coverage is 91.58249% with 25 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (afc9d70) to head (a0f7a93).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   93.38%   90.10%   -3.28%     
==========================================
  Files           4        4              
  Lines         423      465      +42     
==========================================
+ Hits          395      419      +24     
- Misses         28       46      +18     
Files Coverage Δ
chip8/config.py 100.00% <ø> (ø)
chip8/screen.py 90.32% <86.48%> (-9.68%) ⬇️
chip8/cpu.py 97.27% <96.38%> (-1.76%) ⬇️
chip8/emulator.py 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc9d70...a0f7a93. Read the comment docs.