Compatibility Update #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change registers from dictionary to object. Change keyboard configuration to match other emulators. Update readme to reflect tested ROMS. Update readme to reflect working status of ROMS. Add shift quirks, change source and target names to x and y. Update workflow Update Codecov action to v4. Add env secret to code coverage action. Run code coverage only on pull requests, update README Add memory size switch. Fix huge bug with timers and extended screen mode. Update README with new compatibility notes. Add more games compability to README. Fix scrolling. Update README and unit tests. Change the wait wait_for_keypress waits so the emulator does not hang.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 93.38% 90.10% -3.28%
==========================================
Files 4 4
Lines 423 465 +42
==========================================
+ Hits 395 419 +24
- Misses 28 46 +18
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of problems with the current emulator. In general, this PR aims to bring the emulator more inline with other emulators such as Octo. This is in preparation of adding the XO-Chip Extensions to make it broadly compatible with any ROM written for Octo.
As discussed on the various Octo pages, there are several key places where the original Chip8 and Super Chip8 language specifications have diverged. This means that not all Chip8 or Super Chip8 ROMs were running correctly under the original emulator, since each developer may have used a different language specification when writing their programs. Thus, this PR introduces quirk modes, which are optional flags that can be passed to the emulator at run time to ensure the correct language behavior is used when running a given ROM.
Additional changes include: