Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example cps file #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix example cps file #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sample.cps
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@
"components": {
"sample-core": {
"type": "interface",
"definitions": [ "SAMPLE" ],
"definitions": {
"*": {
"SAMPLE": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The "old" version was SAMPLE, which under the new schema should have a value of null. The empty string corresponds to the old schema SAMPLE=. (Same later.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be "SAMPLE": null?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we have to update the type. https://cps-org.github.io/cps/schema.html#definitions says it is a mapping to string and not to string | null

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #70.

}
},
"includes": [ "@prefix@/include" ]
},
"sample": {
Expand Down Expand Up @@ -44,7 +48,11 @@
},
"sample-static": {
"type": "archive",
"definitions": [ "SAMPLE_STATIC" ],
"definitions": {
"*": {
"SAMPLE_STATIC": ""
}
},
"requires": [ ":sample-core" ],
"configurations": {
"optimized": {
Expand Down