-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example cps file #67
base: master
Are you sure you want to change the base?
Conversation
According to the schema this must be a map from languages to a key value map
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted, we should probably add cps_version
while we're at it.
"definitions": [ "SAMPLE" ], | ||
"definitions": { | ||
"*": { | ||
"SAMPLE": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect. The "old" version was SAMPLE
, which under the new schema should have a value of null
. The empty string corresponds to the old schema SAMPLE=
. (Same later.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it should be "SAMPLE": null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we have to update the type. https://cps-org.github.io/cps/schema.html#definitions says it is a mapping to string and not to string | null
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #70.
According to the schema this must be a map from languages to a key value map.