Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example cps file #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

autoantwort
Copy link
Contributor

According to the schema this must be a map from languages to a key value map.

According to the schema this must be a map from languages to a key value map
@LecrisUT
Copy link

LecrisUT commented Jul 2, 2024

cps_version is also missing. Hint, on PyCharm, you can make .cps file be considered a json file, and then add the _site/cps.schema.json as its json schema to validate

Copy link
Member

@mwoehlke mwoehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted, we should probably add cps_version while we're at it.

"definitions": [ "SAMPLE" ],
"definitions": {
"*": {
"SAMPLE": ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The "old" version was SAMPLE, which under the new schema should have a value of null. The empty string corresponds to the old schema SAMPLE=. (Same later.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it should be "SAMPLE": null?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we have to update the type. https://cps-org.github.io/cps/schema.html#definitions says it is a mapping to string and not to string | null

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants