Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/params: query gRPC service #6585

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Conversation

akhilkumarpilli
Copy link
Contributor

Description

ref: #5921


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #6585 into master will increase coverage by 1.40%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #6585      +/-   ##
==========================================
+ Coverage   56.34%   57.75%   +1.40%     
==========================================
  Files         411      499      +88     
  Lines       24425    29814    +5389     
==========================================
+ Hits        13762    17218    +3456     
- Misses       9575    11352    +1777     
- Partials     1088     1244     +156     

@akhilkumarpilli akhilkumarpilli force-pushed the akhil/5921-params-grpc branch 3 times, most recently from c8c70d7 to dd10041 Compare July 7, 2020 12:44
@akhilkumarpilli akhilkumarpilli force-pushed the akhil/5921-params-grpc branch from dd10041 to 5f64416 Compare July 8, 2020 15:24
@akhilkumarpilli akhilkumarpilli marked this pull request as ready for review July 8, 2020 15:25
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 8, 2020
@mergify mergify bot merged commit 674845c into cosmos:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants