Fix protobuf lint issues

cosmos · Jul 8, 2020 · 5f64416 · 5f64416
1 parent e2ab7fd
commit 5f64416
Show file tree

Hide file tree

Showing 5 changed files with 87 additions and 87 deletions.
diff --git a/proto/cosmos/params/query.proto b/proto/cosmos/params/query.proto
@@ -9,17 +9,17 @@ option go_package = "github.com/cosmos/cosmos-sdk/x/params/types/proposal";
 // Query creates service with Parameters as rpc
 service Query{
     // Parameters queries all params
-    rpc Parameters (QuerySubspaceParamsRequest) returns (QuerySubspaceParamsResponse) {}
+    rpc Parameters (QueryParametersRequest) returns (QueryParametersResponse) {}
 }
 
-// QuerySubspaceParamsRequest is request type for the Query/Parameters RPC method
-message QuerySubspaceParamsRequest{
+// QueryParametersRequest is request type for the Query/Parameters RPC method
+message QueryParametersRequest{
     string subspace = 1;
 
     string key = 2;
 }
 
-// QuerySubspaceParamsResponse is response type for the Query/Parameters RPC method
-message QuerySubspaceParamsResponse{
+// QueryParametersResponse is response type for the Query/Parameters RPC method
+message QueryParametersResponse{
     cosmos.params.ParamChange params = 1 [(gogoproto.nullable) = false];
 } 
diff --git a/x/params/keeper/grpc_query.go b/x/params/keeper/grpc_query.go
@@ -14,7 +14,7 @@ import (
 var _ proposal.QueryServer = Keeper{}
 
 // Parameters returns subspace params
-func (k Keeper) Parameters(c context.Context, req *proposal.QuerySubspaceParamsRequest) (*proposal.QuerySubspaceParamsResponse, error) {
+func (k Keeper) Parameters(c context.Context, req *proposal.QueryParametersRequest) (*proposal.QueryParametersResponse, error) {
 	if req == nil {
 		return nil, status.Errorf(codes.InvalidArgument, "empty request")
 	}
@@ -32,5 +32,5 @@ func (k Keeper) Parameters(c context.Context, req *proposal.QuerySubspaceParamsR
 	rawValue := ss.GetRaw(ctx, []byte(req.Key))
 	params := proposal.NewParamChange(req.Subspace, req.Key, string(rawValue))
 
-	return &proposal.QuerySubspaceParamsResponse{Params: params}, nil
+	return &proposal.QueryParametersResponse{Params: params}, nil
 }
diff --git a/x/params/keeper/grpc_query_test.go b/x/params/keeper/grpc_query_test.go
@@ -10,7 +10,7 @@ import (
 
 func (suite *KeeperTestSuite) TestGRPCQueryParams() {
 	var (
-		req      *proposal.QuerySubspaceParamsRequest
+		req      *proposal.QueryParametersRequest
 		expValue string
 		space    types.Subspace
 	)
@@ -24,21 +24,21 @@ func (suite *KeeperTestSuite) TestGRPCQueryParams() {
 		{
 			"empty request",
 			func() {
-				req = &proposal.QuerySubspaceParamsRequest{}
+				req = &proposal.QueryParametersRequest{}
 			},
 			false,
 		},
 		{
 			"invalid request with subspace not found",
 			func() {
-				req = &proposal.QuerySubspaceParamsRequest{Subspace: "test"}
+				req = &proposal.QueryParametersRequest{Subspace: "test"}
 			},
 			false,
 		},
 		{
 			"invalid request with subspace and key not found",
 			func() {
-				req = &proposal.QuerySubspaceParamsRequest{Subspace: "test", Key: "key"}
+				req = &proposal.QueryParametersRequest{Subspace: "test", Key: "key"}
 			},
 			false,
 		},
@@ -47,7 +47,7 @@ func (suite *KeeperTestSuite) TestGRPCQueryParams() {
 			func() {
 				space = suite.app.ParamsKeeper.Subspace("test").
 					WithKeyTable(types.NewKeyTable(types.NewParamSetPair(key, paramJSON{}, validateNoOp)))
-				req = &proposal.QuerySubspaceParamsRequest{Subspace: "test", Key: "key"}
+				req = &proposal.QueryParametersRequest{Subspace: "test", Key: "key"}
 				expValue = ""
 			},
 			true,
@@ -57,7 +57,7 @@ func (suite *KeeperTestSuite) TestGRPCQueryParams() {
 			func() {
 				err := space.Update(suite.ctx, key, []byte(`{"param1":"10241024"}`))
 				suite.Require().NoError(err)
-				req = &proposal.QuerySubspaceParamsRequest{Subspace: "test", Key: "key"}
+				req = &proposal.QueryParametersRequest{Subspace: "test", Key: "key"}
 				expValue = `{"param1":"10241024"}`
 			},
 			true,

diff --git a/x/params/types/proposal/proposal.go b/x/params/types/proposal/proposal.go
@@ -101,9 +101,9 @@ func ValidateChanges(changes []ParamChange) error {
 	return nil
 }
 
-// NewQuerySubspaceParamsRequest returns the new instance of QuerySubspaceParamsRequest
-func NewQuerySubspaceParamsRequest(ss, key string) *QuerySubspaceParamsRequest {
-	return &QuerySubspaceParamsRequest{
+// NewQueryParametersRequest returns the new instance of QueryParametersRequest
+func NewQueryParametersRequest(ss, key string) *QueryParametersRequest {
+	return &QueryParametersRequest{
 		Subspace: ss,
 		Key:      key,
 	}