Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.37.4-rc1 Cherry Picks #5262

Merged
merged 5 commits into from
Oct 30, 2019
Merged

v0.37.4-rc1 Cherry Picks #5262

merged 5 commits into from
Oct 30, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Oct 29, 2019

Cherry-Pick the following from master:


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Re-reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #5262 into rc1/v0.37.4 will decrease coverage by <.01%.
The diff coverage is 83.33%.

@@               Coverage Diff               @@
##           rc1/v0.37.4    #5262      +/-   ##
===============================================
- Coverage        50.98%   50.98%   -0.01%     
===============================================
  Files              290      290              
  Lines            18850    18854       +4     
===============================================
+ Hits              9611     9612       +1     
- Misses            8546     8549       +3     
  Partials           693      693

@alexanderbez alexanderbez marked this pull request as ready for review October 30, 2019 13:57
@alexanderbez alexanderbez added R4R and removed WIP labels Oct 30, 2019
@alexanderbez alexanderbez merged commit eef3ec7 into rc1/v0.37.4 Oct 30, 2019
@alexanderbez alexanderbez deleted the rc0/v0.37.4 branch October 30, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants