remove duplicate events from previous messages #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Oct 16, 2019
|
|
||
| // stop execution and return on first failed message | ||
| if !msgResult.IsOK() { | ||
| msgLogs = append(msgLogs, sdk.NewABCIMessageLog(uint16(i), false, msgResult.Log, events)) | ||
| msgLogs = append(msgLogs, sdk.NewABCIMessageLog(uint16(i), false, msgResult.Log, msgEvents)) |
There was a problem hiding this comment.
bugfix is here
alexanderbez
commented
Oct 16, 2019
|
|
||
| code = msgResult.Code | ||
| codespace = msgResult.Codespace | ||
| break | ||
| } | ||
|
|
||
| msgLogs = append(msgLogs, sdk.NewABCIMessageLog(uint16(i), true, msgResult.Log, events)) | ||
| msgLogs = append(msgLogs, sdk.NewABCIMessageLog(uint16(i), true, msgResult.Log, msgEvents)) |
fedekunze
approved these changes
Oct 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #5208 +/- ##
==========================================
+ Coverage 53.42% 53.44% +0.01%
==========================================
Files 290 290
Lines 17711 17714 +3
==========================================
+ Hits 9462 9467 +5
+ Misses 7510 7508 -2
Partials 739 739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5200
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.mdRe-reviewed
Files changedin the github PR explorerFor Admin Use: