Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AppendTags usage error #4274

Closed
wants to merge 1 commit into from
Closed

fix AppendTags usage error #4274

wants to merge 1 commit into from

Conversation

cryptophonic
Copy link

@cryptophonic cryptophonic commented May 5, 2019 •
edited by alexanderbez
Loading

closes: #4273

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • [X ] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • [N/A ] Wrote tests
  • [N/A ] Updated relevant documentation (docs/)
  • [N/A ] Added a relevant changelog entry: clog add [section] [stanza] [message]
  • [X ] rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@zmanian
Copy link
Member

zmanian commented May 5, 2019

I think this should be targeted to develop instead of master even though it's a bug fix but correct me if I am wrong @alexanderbez

@alessio
Copy link
Contributor

alessio commented May 5, 2019

@zmanian develop has been dropped, thus master is the right target of this PR. It may be appropriate to backport the fix to the latest release though.

@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #4274 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4274   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files         217      217           
  Lines       14595    14595           
=======================================
  Hits         8625     8625           
  Misses       5332     5332           
  Partials      638      638

1 similar comment
@codecov
Copy link

codecov bot commented May 5, 2019

Codecov Report

Merging #4274 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #4274   +/-   ##
=======================================
  Coverage   59.09%   59.09%           
=======================================
  Files         217      217           
  Lines       14595    14595           
=======================================
  Hits         8625     8625           
  Misses       5332     5332           
  Partials      638      638

@alessio alessio requested a review from fedekunze May 6, 2019 10:11
@alessio
Copy link
Contributor

alessio commented May 6, 2019

Can you add a pending entry please? The following would do it:

go get -u github.com/alessio/clog
clog add bugfixes sdk '#4274 Fix AppendTags usage in x/staking/handler.go.'
git add .pending/bugfixes/sdk/

fedekunze
fedekunze approved these changes May 6, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending clog entry

alexanderbez
alexanderbez suggested changes May 6, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ACK pending a pending log entry. Do you mind adding one please @mjackson001?

jackzampolin
jackzampolin approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Needs pending!

@alessio alessio mentioned this pull request May 14, 2019
Merged
5 tasks
@alessio
Copy link
Contributor

alessio commented May 14, 2019

New PR w/ @mjackson001 changes + pending entry: #4336

alessio pushed a commit that referenced this pull request May 14, 2019
Fix AppendTags usage error (#4336)
262c752 
Fix AppendTags usage error

Thanks: @mjackson001 for the bug report and patch (original PR: #4274)
Closes: #4273
@alessio
Copy link
Contributor

alessio commented May 14, 2019

Fixed in 262c752

@alessio alessio closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez requested changes

@fedekunze fedekunze fedekunze approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppendTags usage issue in x/staking/handler.go
6 participants
@cryptophonic @zmanian @alessio @alexanderbez @jackzampolin @fedekunze