We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark [12:06 PM] in x/staking/handler.go there are a couple sections of code that looks like:
resTags.AppendTags(sdk.NewTags( tags.Action, tags.ActionCompleteUnbonding, tags.Delegator, dvPair.DelegatorAddress.String(), tags.SrcValidator, dvPair.ValidatorAddress.String(), ))
this code will have no effect on resTags itself because AppendTags() returns its result and does not modify its base object. Should be:
resTags = resTags.AppendTags(sdk.NewTags( tags.Action, tags.ActionCompleteUnbonding, tags.Delegator, dvPair.DelegatorAddress.String(), tags.SrcValidator, dvPair.ValidatorAddress.String(), ))
Zaki Manian [12:08 PM] yes that's a bug Make a PR?
Mark[12:08 PM] yup will do
Latest SDK code - master branch
N/A code review produce the issue, confirmed with Zaki
The text was updated successfully, but these errors were encountered:
Fix AppendTags usage error (#4336)
262c752
Fix AppendTags usage error Thanks: @mjackson001 for the bug report and patch (original PR: #4274) Closes: #4273
Successfully merging a pull request may close this issue.
Summary of Bug
Mark [12:06 PM]
in x/staking/handler.go there are a couple sections of code that looks like:
this code will have no effect on resTags itself because AppendTags() returns its result and does not modify its base object. Should be:
Zaki Manian [12:08 PM]
yes that's a bug
Make a PR?
Mark[12:08 PM]
yup will do
Version
Latest SDK code - master branch
Steps to Reproduce
N/A code review produce the issue, confirmed with Zaki
For Admin Use
The text was updated successfully, but these errors were encountered: