Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Add warning and disclaimer #3572

Merged
merged 1 commit into from
Feb 9, 2019
Merged

R4R: Add warning and disclaimer #3572

merged 1 commit into from
Feb 9, 2019

Conversation

ebuchman
Copy link
Member

@ebuchman ebuchman commented Feb 9, 2019

Legal recommendations :)

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ebuchman ebuchman changed the title Add warning and disclaimer R4R: Add warning and disclaimer Feb 9, 2019
@codecov
Copy link

codecov bot commented Feb 9, 2019

Codecov Report

Merging #3572 into develop will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3572      +/-   ##
===========================================
+ Coverage    61.39%   61.42%   +0.02%     
===========================================
  Files          185      185              
  Lines        14006    14006              
===========================================
+ Hits          8599     8603       +4     
+ Misses        4855     4851       -4     
  Partials       552      552

@ebuchman ebuchman merged commit 14c0476 into develop Feb 9, 2019
@ebuchman ebuchman deleted the bucky/delegator-guide branch February 9, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants