-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos #23152
docs: fix typos #23152
Conversation
Signed-off-by: oliveredget <188809800+oliveredget@users.noreply.github.com>
📝 WalkthroughWalkthroughThe pull request focuses on correcting terminology in the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
x/accounts/defaults/lockup/README.md (2)
121-125
: Fix punctuation and formatting inconsistencies
- Add a comma after the formula for better readability
- Maintain consistent bullet point formatting
-`notBondedLockedAmount` can only be 0 or a positive value when `DelegatedLockedAmount` < `LockedAmount`. Let call +`notBondedLockedAmount` can only be 0 or a positive value when `DelegatedLockedAmount` < `LockedAmount`. Let's call - * When not applying slash `notBondedLockedAmount` will be 0 - * When apply slash `notBondedLockedAmount` will be `lockedAmount` - `NewDelegatedLockedAmount` = a positive amount +* When not applying slash, `notBondedLockedAmount` will be 0 +* When applying slash, `notBondedLockedAmount` will be `lockedAmount` - `NewDelegatedLockedAmount` = a positive amount🧰 Tools
🪛 LanguageTool
[uncategorized] ~121-~121: Possible missing comma found.
Context: ...mount, delegatedLockedAmount)As seen in the formula
notBondedLockedAmount` can...(AI_HYDRA_LEO_MISSING_COMMA)
128-129
: Improve formula readability and consistencyThe formula explanation would be clearer with proper spacing and consistent terminology.
- * When apply slash `notBondedLockedAmount` will be `lockedAmount` - `NewDelegatedLockedAmount` = `lockedAmount` - `(DelegatedLockedAmount - N)` = `lockedAmount` - `DelegatedLockedAmount` + N + * When applying slash, `notBondedLockedAmount` will be: + `lockedAmount` - `NewDelegatedLockedAmount` = `lockedAmount` - (`DelegatedLockedAmount` - N) = `lockedAmount` - `DelegatedLockedAmount` + N
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
x/accounts/defaults/lockup/README.md
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/accounts/defaults/lockup/README.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
x/accounts/defaults/lockup/README.md
[uncategorized] ~121-~121: Possible missing comma found.
Context: ...mount, delegatedLockedAmount) As seen in the formula
notBondedLockedAmount` can...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (1)
x/accounts/defaults/lockup/README.md (1)
Line range hint
1-129
: Documentation changes look good!The documentation effectively explains the lockup account types and slashing behavior. The examples are comprehensive and technically accurate.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~121-~121: Possible missing comma found.
Context: ...mount, delegatedLockedAmount)As seen in the formula
notBondedLockedAmount` can...(AI_HYDRA_LEO_MISSING_COMMA)
Description
This PR focuses on correcting typos and improving clarity in documentation files.
Thank you very much.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit