tools: Add unparam linter #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e583ed2 to
cd9b0b0
Compare
unparam detects unused parameters in functions, and a parameter to a function which only ever takes on one value. The latter is an indication that more tests are required. There are many nolints in this PR, as I believe that writing tests to fix alot of these situations is out of scope for this PR / it will be changed in future commits. There are some nolints for when we have to comply to normal api's.
cd9b0b0 to
cc2b179
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1443 +/- ##
==========================================
Coverage ? 63.09%
==========================================
Files ? 118
Lines ? 6563
Branches ? 0
==========================================
Hits ? 4141
Misses ? 2151
Partials ? 271 |
|
Amazing - it's shocking how many parameters where left behind - I think this linter is going to save a lot of energy for us. |
rigelrozanski
approved these changes
Jun 29, 2018
|
p.s. this is hilariously annoying updating the branch and then waiting for it to pass, and then having to update the branch again - wish there was a "run tests and if they pass, merge immediately" button |
|
Not sure why upload coverage hasn't terminated :/ |
adrianbrink
pushed a commit
that referenced
this pull request
Jul 2, 2018
* tools: Add unparam linter unparam detects unused parameters in functions, and a parameter to a function which only ever takes on one value. The latter is an indication that more tests are required. There are many nolints in this PR, as I believe that writing tests to fix alot of these situations is out of scope for this PR / it will be changed in future commits. There are some nolints for when we have to comply to normal api's. * crypto/keys no longer used by x/gov/client/rest/rest.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unparam detects unused parameters in functions, and a parameter to
a function which only ever takes on one value. The latter is an
indication that more tests are required.
There are many nolints in this PR, as I believe that writing tests
to fix alot of these situations is out of scope for this PR / it
will be changed in future commits. There are some nolints for
when we have to comply to normal api's.
ref #1417 , closes #1084