Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unused function inputs #1084

Closed
rigelrozanski opened this issue May 30, 2018 · 1 comment · Fixed by #1443
Closed

Check for unused function inputs #1084

rigelrozanski opened this issue May 30, 2018 · 1 comment · Fixed by #1443
Labels

Comments

@rigelrozanski
Copy link
Contributor

When function inputs are no longer used, they should either be removed from the function - if they can't be removed they need to referenced in the function - this should be built into CI.

REF: #994 (comment)

CC: @melekes - ever seen anything that can do this?

@rigelrozanski
Copy link
Contributor Author

https://github.com/mvdan/unparam looks good - kind of confusing to use however -> try:
unparam ./... or unparam ./x/... for instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants