-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make makefile and ci match #13208
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b37ff92
ci: make makefile and ci match
faddat 6b497da
Update lint.yml
faddat a732af4
Delete tools.go
faddat 3136815
Update Makefile
faddat f760a72
Merge branch 'main' into patch-19
alexanderbez 08f8db2
Update Makefile
faddat 654127c
Merge branch 'main' into patch-19
faddat e40221e
tidy
faddat 0491f70
Merge branch 'main' into patch-19
faddat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,27 @@ | ||
| name: Lint | ||
| # Lint runs golangci-lint over the entire cosmos-sdk repository | ||
| # This workflow is run on every pull request and push to main | ||
| # The `golangci` will pass without running if no *.{go, mod, sum} files have been changed. | ||
| on: | ||
| pull_request: | ||
| push: | ||
| tags: | ||
| - v* | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| permissions: | ||
| contents: read | ||
|
|
||
| # Optional: allow read access to pull request. Use with `only-new-issues` option. | ||
| # pull-requests: read | ||
| jobs: | ||
| golangci: | ||
| permissions: | ||
| pull-requests: read # for technote-space/get-diff-action to get git reference | ||
| name: golangci-lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.18 | ||
| # ci is set to go1.19 to match developer setups | ||
| go-version: 1.19 | ||
| - uses: actions/checkout@v3 | ||
| - uses: technote-space/get-diff-action@v6.1.0 | ||
| id: git_diff | ||
| with: | ||
| PATTERNS: | | ||
| **/**.go | ||
| go.mod | ||
| go.sum | ||
| - name: Get data from Go build cache | ||
| # if: env.GIT_DIFF | ||
| if: ${{ false }} | ||
| uses: actions/cache@v3 | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| path: | | ||
| ~/go/pkg/mod | ||
| ~/.cache/golangci-lint | ||
| ~/.cache/go-build | ||
| key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }} | ||
| - name: Run golangci-lint | ||
| if: env.GIT_DIFF | ||
| run: make lint | ||
| # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||
| version: latest | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why latest? this may cause issues when new versions come out and break ci unexpectedly