ci: make makefile and ci match #13208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
reviewed
Sep 8, 2022
alexanderbez
approved these changes
Sep 8, 2022
julienrbrt
reviewed
Sep 8, 2022
| package tools | ||
|
|
||
| import ( | ||
| _ "github.com/golangci/golangci-lint/cmd/golangci-lint" |
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #13208 +/- ##
==========================================
- Coverage 53.72% 53.69% -0.04%
==========================================
Files 652 647 -5
Lines 55407 55252 -155
==========================================
- Hits 29770 29666 -104
+ Misses 23256 23212 -44
+ Partials 2381 2374 -7
|
julienrbrt
approved these changes
Sep 8, 2022
tac0turtle
reviewed
Sep 11, 2022
| @@ -1,12 +0,0 @@ | |||
| //go:build tools | |||
There was a problem hiding this comment.
I think this broke main, I cant run make lint here as the make file was never updated correctly
tac0turtle
reviewed
Sep 11, 2022
| if: env.GIT_DIFF | ||
| run: make lint | ||
| # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||
| version: latest |
There was a problem hiding this comment.
why latest? this may cause issues when new versions come out and break ci unexpectedly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the Makefile match ci, and updates ci to use the canonical golangci-lint github action.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change