Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Store Tests CI Job #17341

Closed
Tracked by #17041
alexanderbez opened this issue Aug 9, 2023 · 1 comment · Fixed by #17416
Closed
Tracked by #17041

Update Store Tests CI Job #17341

alexanderbez opened this issue Aug 9, 2023 · 1 comment · Fixed by #17416
Assignees
@alexanderbez
Labels
C:Store

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Aug 9, 2023 •
edited
Loading

We need to be able to test the RocksDB based SS engine in CI. However, this requires the RocksDB shared libs to linked. It would take way too much time to install RocksDB on each CI run. Instead, we should create an image based off of ubuntu latest, which has the following:

  • RocksDB stable 8.3.2 (and required deps: gcc, make, g++, gflags, lz4, snappy, zstd)
  • Golang v1.21.x
@alexanderbez alexanderbez mentioned this issue Aug 9, 2023
Open
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Aug 9, 2023
@alexanderbez alexanderbez added C:Store WG: Storage and removed needs-triage Issue that needs to be triaged labels Aug 9, 2023
@yihuang yihuang mentioned this issue Aug 10, 2023
Merged
20 tasks
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Aug 11, 2023
@yihuang
support build with rocksdb backend in CI
24ab15c 
WIP: cosmos#17341

- bump cometbft-db dependency to switch to grocksdb
- add nix flakes to help build with rocksdb dependency
@alexanderbez
Copy link
Contributor Author

@yihuang could you help me figure out how to take the work you've done and update the test-store CI job to use nix s.t. we can run the rocksdb package tests please?

@yihuang yihuang mentioned this issue Aug 17, 2023
Merged
20 tasks
yihuang added a commit to yihuang/cosmos-sdk that referenced this issue Aug 22, 2023
@yihuang
ci: update test workflow to use rocksdb dependency
89530f4 
Closes: cosmos#17341

some modules don't need rocksdb

restraint to store module
@alexanderbez alexanderbez self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:Store
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: update test workflow to use rocksdb dependency yihuang/cosmos-sdk
1 participant
@alexanderbez