Update asdf elixir version for gradual typing #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - The latest elixir has nice gradual typing. This PR updates to the latest version to bring that in. - Bump OTP as well Test Plan: - make integration.kind - mix compile --force --warnings-as-errors
40388b0 to
b3c0f3b
Compare
Summary: - Add the latest elixir and otp version to the testing matrix. We've been running them at BatteriesIncluded for a while on the latest versions. - Remove the restore keys field for plts. This causes us to re-generate new typespecs on new elixir versions (new otp versions as well but they don't seem to change the plts as much) Test Plan: - Green CI
b3c0f3b to
8cd4293
Compare
|
The failure is a real dialyzer error that comes from the upgraded elixir. |
Summary: - Fix dialyzer error Test Plan: - CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update asdf elixir/otp versions
Summary:
latest version to bring that in.
Test Plan: