Skip to content

Commit

Permalink
fix: update github ci workflows for new version
Browse files Browse the repository at this point in the history
Summary:
- Add the latest elixir and otp version to the testing matrix. We've
  been running them at BatteriesIncluded for a while on the latest
  versions.
- Remove the restore keys field for plts. This causes us to re-generate
  new typespecs on new elixir versions (new otp versions as well but
  they don't seem to change the plts as much)

Test Plan:
- Green CI
  • Loading branch information
elliottneilclark committed Jan 7, 2025
1 parent c434347 commit 8cd4293
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:

- name: Setup elixir
uses: erlef/setup-beam@v1
id: beam
with:
version-file: .tool-versions
version-type: strict
Expand All @@ -52,8 +53,6 @@ jobs:
with:
key: |
${{ runner.os }}-${{ steps.beam.outputs.elixir-version }}-${{ steps.beam.outputs.otp-version }}-plt
restore-keys: |
${{ runner.os }}-${{ steps.beam.outputs.elixir-version }}-${{ steps.beam.outputs.otp-version }}-plt
path: |
priv/plts
Expand Down
16 changes: 13 additions & 3 deletions .github/workflows/elixir_matrix.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,24 @@ jobs:
fail-fast: false
matrix:
# See https://hexdocs.pm/elixir/1.13/compatibility-and-deprecations.html#compatibility-between-elixir-and-erlang-otp
otp: ["23.x", "24.x", "25.x", "26.x"]
elixir: ["1.14.x", "1.15.x", "1.16.x"]
otp: ["23.x", "26.x", "27.x"]
elixir: ["1.14.x", "1.17.x", "1.18.x"]
exclude:
# OTP 23
- elixir: "1.15.x"
otp: "23.x"
- elixir: "1.16.x"
- elixir: "1.17.x"
otp: "23.x"
- elixir: "1.18.x"
otp: "23.x"
# OTP 26
# - Users on recent elixir likely updated OTP versions
- elixir: "1.18.x"
otp: "26.x"
# OTP 27 - Elixir 1.14.x is not compatible with OTP 27
- elixir: "1.14.x"
otp: "27.x"


steps:
- uses: actions/checkout@v4.1.7
Expand Down

0 comments on commit 8cd4293

Please sign in to comment.