Add types for int / uint 8, 16, 32, 64, float 32 and 64 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corymickelson
added a commit
that referenced
this pull request
Oct 5, 2019
…riements Add types for int / uint 8, 16, 32, 64, float 32 and 64
corymickelson
added a commit
that referenced
this pull request
Oct 5, 2019
…riements Add types for int / uint 8, 16, 32, 64, float 32 and 64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds more granular numeric types, uses copies instead of references to nodes where ownership should not be passed, updates node.Children to return a reference to the child for size reasons(children can be large, avoid copy), add default value and type to new node constructor, replace slice with fixed size array where possible.