Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable active query tracker in querier test #5318

Merged

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented May 3, 2023

What this PR does:

This pr disables active query tracker in querier tests so that we can parallelize our tests without being impacted by mmap error mentioned in the linked issue.

Also upgraded the Thanos promql engine to get the fix thanos-io/promql-engine@c5232b7 so that we can parallelize it as well.

Which issue(s) this PR fixes:
Fixes #5314

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@pull-request-size pull-request-size bot added size/M and removed size/XS labels May 3, 2023
@yeya24 yeya24 changed the title remove parallel tests if we create a query engine in the test Disable active query tracker in querier test May 3, 2023
@friedrichg friedrichg merged commit 04566a5 into cortexproject:master May 4, 2023
@yeya24 yeya24 deleted the more-querier-concurrent-test-fix branch May 10, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concurrent querier tests cause panic
3 participants