Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent querier tests cause panic #5314

Closed
yeya24 opened this issue May 2, 2023 · 2 comments · Fixed by #5318
Closed

Concurrent querier tests cause panic #5314

yeya24 opened this issue May 2, 2023 · 2 comments · Fixed by #5318

Comments

@yeya24
Copy link
Contributor

yeya24 commented May 2, 2023

Describe the bug
We have concurrent querier tests and seems it caused panic on github.com/prometheus/prometheus/promql.NewActiveQueryTracker due to mmap.

Example https://github.com/cortexproject/cortex/actions/runs/4855256141/jobs/8654944409?pr=5303.

My suggestion here is to disable concurrent tests if query engine is created in the test.
@friedrichg
Copy link
Member

Good suggestion. I agree.

@yeya24 yeya24 mentioned this issue May 3, 2023
Merged
3 tasks
@yeya24
Copy link
Contributor Author

yeya24 commented May 3, 2023

Actually another way is to just disable the active query tracker to avoid mmap.
I think it is better to do as we don't need active query tracker in test and we can still parallize our tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable active query tracker in querier test yeya24/cortex
2 participants
@friedrichg @yeya24