-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingester: Added configuration to set the size of the tsdb in-memory queue used before flushing chunks to the disk #5000
Conversation
Nice! @t00350320 Could you please sign the DCO and fix the lint? |
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thanks for the contribution. Would you mind resolving the conflict again? @t00350320 Thanks!
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
Maybe @alanprot @friedrichg would like to take another look? |
…llowing to configure the size of the in-memory queue used before flushing chunks to the disk . cortexproject#5000 Signed-off-by: tanghengjian <1040104807@qq.com>
Signed-off-by: tanghengjian <1040104807@qq.com>
This pr LGTM. It would be appreciated if we could have another 👁️ on it. WDYT? @alanprot @friedrichg |
Awesome! thanks! |
What this PR does:
Added configuration to set the size of the tsdb in-memory queue used before flushing chunks to the disk
Which issue(s) this PR fixes:
Fixes #
#4957
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]