Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async tsdb chunkswrite needs a configuration #4957

Closed
t00350320 opened this issue Nov 7, 2022 · 3 comments
Closed

async tsdb chunkswrite needs a configuration #4957

t00350320 opened this issue Nov 7, 2022 · 3 comments
Labels
type/feature

Comments

@t00350320
Copy link
Contributor

AFAK, vendor/prometheus has imported an async tsdb chunkswrite method. Related configuration is a hard code with "DefaultWriteQueueSize = 0". We'll add a configuration in yaml file.
@yeya24
Copy link
Contributor

yeya24 commented Nov 9, 2022

Yeah I think it makes sense to expose the configuration. @t00350320 Would you like to submit a PR?

@t00350320
Copy link
Contributor Author

Yeah I think it makes sense to expose the configuration. @t00350320 Would you like to submit a PR?

yeah, i will do it.

@t00350320 t00350320 mentioned this issue Nov 25, 2022
Merged
3 tasks
@alanprot
Copy link
Member

Closing this as the PR got merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alvinlin123 @alanprot @yeya24 @t00350320