Fix some cases where flush reason is recorded as 'Immediate' #2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan Boreham <bryan@weave.works>
Pass the reason from `shouldFlushChunk()` to `closeHead()`; sending `reasonImmediate` was a bug. We don't need to check `len(chunks)` is non-zero, since that would return `noFlush` from `shouldFlushSeries()`. Signed-off-by: Bryan Boreham <bryan@weave.works>
pracucci
approved these changes
Jan 22, 2020
codesome
added a commit
to grafana/cortex
that referenced
this pull request
Jan 23, 2020
commit df8b95f Author: Bryan Boreham <bryan@weave.works> Date: Wed Jan 22 13:52:44 2020 +0000 Pass the correct flush reason to closeHead() Pass the reason from `shouldFlushChunk()` to `closeHead()`; sending `reasonImmediate` was a bug. We don't need to check `len(chunks)` is non-zero, since that would return `noFlush` from `shouldFlushSeries()`. Signed-off-by: Bryan Boreham <bryan@weave.works> commit 17c0c21 Author: Bryan Boreham <bryan@weave.works> Date: Wed Jan 22 13:45:22 2020 +0000 Make sure we return noFlush on an empty series Signed-off-by: Bryan Boreham <bryan@weave.works> Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the reason from
shouldFlushChunk()tocloseHead(); sendingreasonImmediatewas a bug introduced in #1978.We don't need to check
len(chunks)is non-zero, since that would returnnoFlushfromshouldFlushSeries().Also close the gap where
reasonImmediatecould be returned on an empty series, which would then have crashed. Don't know if it's possible in practice to get that state.