Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 #2020

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Release 0.6.0 #2020

merged 7 commits into from
Jan 28, 2020

Conversation

pracucci
Copy link
Contributor

What this PR does:
In this PR I've prepared the 0.6.0 release cut from master at ab3e8360fe30150a516448e4c3bae596dc4d8a17. I went through the changelog (using a script committed here as well) and added missing entries for PRs which are user facing.

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci
Copy link
Contributor Author

Does this ec2d8c4#r36911693 blocks the release until a fix is provided?

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@bboreham
Copy link
Contributor

@pracucci I made a fix #2022
Do you want me to target that at the release branch?

@pracucci
Copy link
Contributor Author

Do you want me to target that at the release branch?

@bboreham No thanks. Let me review #2022 and then will cherry pick it.

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would benefit from tidying.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
Note that the ruler flags need to be changed in this upgrade. You're moving from a single node ruler to something that might need to be sharded.
If you are running with a high `-ruler.num-workers` and if you're not able to execute all your rules in `-ruler.evaluation-interval`, then you'll need to shard.
Further, if you're using the configs service, we've upgraded the migration library and this requires some manual intervention. See full
instructions below to upgrade your Postgres.
instructions below to upgrade your PostgreSQL.

* [CHANGE] Remove unnecessary configs/flags from the ruler ring config to align with the pattern used in the distributor ring. #1987
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release 0.4 didn't have a ruler ring, so these particular differences don't need to be listed as a CHANGE.
It would be good to mention the ring alongside the "transition to upstream Prometheus rules manager"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about now?

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Bryan Boreham <bryan@weave.works>
Pass the reason from `shouldFlushChunk()` to `closeHead()`;
sending `reasonImmediate` was a bug.

We don't need to check `len(chunks)` is non-zero, since that would
return `noFlush` from `shouldFlushSeries()`.

Signed-off-by: Bryan Boreham <bryan@weave.works>
@pracucci
Copy link
Contributor Author

Do you want me to target that at the release branch?

@bboreham No thanks. Let me review #2022 and then will cherry pick it.

Cherry picked the PR #2022.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor Author

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bboreham for the feedback. I should have addressed all your comments. May you take a second look, please?

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions. Otherwise, LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
tools/release/check-changelog.sh Show resolved Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Marco Pracucci <marco@pracucci.com>
…valuation_timestamp_seconds metric

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR and changelog; haven't managed to run all the code in production yet but we have it in staging.

@pracucci pracucci merged commit f69ccee into master Jan 28, 2020
@pracucci pracucci deleted the release-0.6 branch January 28, 2020 14:09
@pracucci pracucci restored the release-0.6 branch February 5, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants