Catch and ignore SIGTERM during update operations #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copying the comment from #811
This is an interesting point; I was going to say we don't fork subprocesses but in fact we do. |
champtar
reviewed
Jan 8, 2025
Since our updates are non-transactional in general, we should at least be robust against some concurrent invocation of e.g. `reboot`. Replaces: coreos#811 Signed-off-by: Colin Walters <walters@verbum.org>
Any child processes we fork are not long running, so they don't need their own individual SIGTERM. Doing things this way ensures that when we suppress SIGTERM for our process that's sufficient to ensure the whole unit runs uninterrupted. Signed-off-by: Colin Walters <walters@verbum.org>
56de2ef to
e35436c
Compare
champtar
reviewed
Jan 8, 2025
champtar
reviewed
Jan 8, 2025
And add comments in both places so we remember to keep them in sync. Signed-off-by: Colin Walters <walters@verbum.org>
e35436c to
c9b7964
Compare
champtar
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since our updates are non-transactional in general, we should at least be robust against some concurrent invocation of e.g.
reboot.Replaces: #811