-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay being killed on reboot/poweroff #811
Conversation
Setting KillSignal=SIGCONT is a hack, but it gives us DefaultTimeoutStopSec before being killed (45s on Fedora, 90s on EL9). The proper systemd way would be to use inhibit locks but they are ignored by reboot/poweroff commands, ie you need the systemctl reboot/poweroff variants, and just using systemd-inhibit makes all the logs starts with systemd-inhibit instead of bootupctl.
Hi @champtar. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! I'd prefer to have us explicitly ignore SIGTERM in our own code.
If we want to fully integrate with systemd, we can use sd_notify() and send If we just ignore I'm hello world level in rust so if someone wants to implement this please go ahead |
Since our updates are non-transactional in general, we should at least be robust against some concurrent invocation of e.g. `reboot`. Replaces: coreos#811 Signed-off-by: Colin Walters <walters@verbum.org>
Moving this to #812 Thanks again for submitting a patch though! |
Since our updates are non-transactional in general, we should at least be robust against some concurrent invocation of e.g. `reboot`. Replaces: coreos#811 Signed-off-by: Colin Walters <walters@verbum.org>
Setting KillSignal=SIGCONT is a hack, but it gives us DefaultTimeoutStopSec before being killed (45s on Fedora, 90s on EL9).
The proper systemd way would be to use inhibit locks but they are ignored by reboot/poweroff commands, ie you need the systemctl reboot/poweroff variants, and just using systemd-inhibit makes all the logs starts with systemd-inhibit instead of bootupctl.