This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Revert "Stabilize the identity of the mutate function" #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b75d2a6.
|
Deploy request for restful-react accepted. Accepted with commit ad33f3a https://app.netlify.com/sites/restful-react/deploys/60594245a7fed10007749729 |
amacleay-cohere
added a commit
to amacleay-cohere/restful-react
that referenced
this pull request
Apr 16, 2021
Revisiting contiamo#335 in light of the issue noted in contiamo#337 First of all, stabilize the useMutate function even more by using a deep compare effect. This better handles cases in which the argument to `useMutate` is an inline object, which is the typical use case.
|
prefer #338 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #335
I realized while testing this with a much larger project today that this PR adds a problem: if the identity of the mutate function does happen to change, the
abort()function no longer gets called with the prior instance's abort handler, but the current instance's abort handler! I am working on a fix for this, but in the meantime, #335 should just be reverted in a bugfix release.