This repository has been archived by the owner on Nov 11, 2023. It is now read-only.
Stabilize the identity of the mutate function #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully begins to address contiamo#186 Approach: * Remove (mutable) references to state. Instead, hook into the (immutable) `setState` function in the mutate function body where state references are necessary * Try very hard to be honest about what dependencies may change in the dependency array, but leave only immutable dependencies that depend only on props (almost totally successful)
|
Deploy request for restful-react accepted. Accepted with commit 2731e0a https://app.netlify.com/sites/restful-react/deploys/6052a5c8233f330007496c6e |
kfujita-cohere
approved these changes
Mar 18, 2021
kfujita-cohere
suggested changes
Mar 18, 2021
fabien0102
approved these changes
Mar 22, 2021
amacleay-cohere
added a commit
to amacleay-cohere/restful-react
that referenced
this pull request
Apr 16, 2021
Revisiting contiamo#335 in light of the issue noted in contiamo#337 First of all, stabilize the useMutate function even more by using a deep compare effect. This better handles cases in which the argument to `useMutate` is an inline object, which is the typical use case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully begins to address #186
Approach:
(immutable)
setStatefunction in the mutate function body wherestate references are necessary
dependency array, but leave only immutable dependencies that depend only
on props (almost totally successful)
Why
Hopefully addresses some of #186 , at least with respect to the mutate function.