-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation of commit command to show image reference is optional #5218
Update documentation of commit command to show image reference is optional #5218
Conversation
…ional Following Commit ba1d130 ("make image reference for commit optional") Updates usage text used by cobra and markdown document used to generate MAN page. Fixes: containers#5145 Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
Hi @Jumanjii. Thanks for your PR. I'm waiting for a containers member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM |
Thanks @Jumanjii |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jumanjii, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Following
Commit ba1d130 ("make image reference for commit optional")
Updates usage text used by cobra and markdown document used to generate MAN page.
Closes #5145
Signed-off-by: Allan Jacquet-Cretides allan.jacquet@gmail.com