Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker commit: wrong help text #5145

Closed
loibpet opened this issue Feb 10, 2020 · 3 comments · Fixed by #5218
Closed

docker commit: wrong help text #5145

loibpet opened this issue Feb 10, 2020 · 3 comments · Fixed by #5218
Assignees
@Jumanjii
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@loibpet
Copy link

loibpet commented Feb 10, 2020

/kind bug

Description

Thanks for the quick fix for issue #5027 which is working now as expected.

However, the help text still needs a little update regarding the now removed second mandatory parameter:

podman --version && podman commit --help

podman version 1.8.0

Create new image based on the changed container

Description:
Create an image from a container's changes. Optionally tag the image created, set the author with the --author flag, set the commit message with the --message flag, and make changes to the instructions with the --change flag.

Usage:
  podman commit [flags] CONTAINER IMAGE
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 10, 2020
@rhatdan
Copy link
Member

rhatdan commented Feb 10, 2020

@loibpet Would you be interested in opening a PR to fix this?

@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Feb 10, 2020
@Jumanjii
Copy link
Contributor

@loibpet I don't want to rush this one on you as my first contribution to this project.
Could you just share if you want to do it or if I can create the merge request?

https://github.com/containers/libpod/blob/master/cmd/podman/commit.go#L18

@loibpet
Copy link
Author

loibpet commented Feb 13, 2020

Pls. go on an create a PR

Jumanjii added a commit to Jumanjii/libpod that referenced this issue Feb 15, 2020
@Jumanjii
Update documentation of commit command to show image reference is opt…
59c9106 
…ional

Following
Commit ba1d130 ("make image reference for commit optional")

Updates usage text used by cobra and markdown document used to generate MAN page.

Fixes: containers#5145

Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
@Jumanjii Jumanjii mentioned this issue Feb 15, 2020
Merged
snj33v pushed a commit to snj33v/libpod that referenced this issue May 31, 2020
@Jumanjii @snj33v
Update documentation of commit command to show image reference is opt…
f60cc3b 
…ional

Following
Commit ba1d130 ("make image reference for commit optional")

Updates usage text used by cobra and markdown document used to generate MAN page.

Fixes: containers#5145

Signed-off-by: Allan Jacquet-Cretides <allan.jacquet@gmail.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jumanjii Jumanjii

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation of commit command to show image reference is optional Jumanjii/libpod
4 participants
@rhatdan @Jumanjii @openshift-ci-robot @loibpet