pull: don't resolve short names on explicit docker:// reference

[vrothberg]

Fixes: #581
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@rhatdan @mtrmac PTAL

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtrmac]

ACK.

Esthetically I’d prefer a copySingleImageFromRegistryReference, called by

• explicit docker:// reference like this case
• in a loop, the AllTags implementation looping over tags
• in a loop, in the possibly-unqualified not-transport-qualified case looping over resolution outcome

rather than letting the docker:// reference go through the short-name lookup code and various possible normalization.

OTOH this works, and is much less work.

[rhatdan]

/lgtm

This one we might want to get into Final release?

[vrothberg]

/lgtm

This one we might want to get into Final release?

Shall I backport to the 0.38 branch?

[rhatdan]

I am not sure how often this syntax would be used. So we might be able to wait until podman 3.3.