Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: pull: don't resolve short names on explicit docker:// reference #581

Closed
vrothberg opened this issue May 26, 2021 · 0 comments · Fixed by #582
Closed

libimage: pull: don't resolve short names on explicit docker:// reference #581

vrothberg opened this issue May 26, 2021 · 0 comments · Fixed by #582

Comments

@vrothberg
Copy link
Member

… I might be missing something; how do short names like busybox vs explicit docker://docker.io/busybox pulls work? AFAICS this code parses both into a docker://busybox ImageReference, losing the distinction — and then may try to do short name lookup on explicit docker://… formats, which should, I think, never happen — short name lookup is used only for Docker-like non-transport-qualified formats, so that the c/image-transport-qualified strings always mean the same thing in all callers.

Originally posted by @mtrmac in #579 (comment)

vrothberg added a commit to vrothberg/common that referenced this issue May 26, 2021

Verified

This commit was signed with the committer’s verified signature.
driesvints Dries Vints
Fixes: containers#581
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/common that referenced this issue May 26, 2021
Fixes: containers#581
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/common that referenced this issue May 26, 2021
Fixes: containers#581
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/common that referenced this issue May 26, 2021
Fixes: containers#581
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant